From 307f62401594d6a9c7dd4aa4b2e1739a7f6c6657 Mon Sep 17 00:00:00 2001
From: Patrick Alvin Alcala <patrick_alv@yahoo.com>
Date: Thu, 5 Jun 2025 15:49:59 +0800
Subject: [PATCH] Improved createEffect and cleanup

---
 .../Password-Generator/PasswordGeneratorComponent.tsx     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/PageComponents/Password-Generator/PasswordGeneratorComponent.tsx b/src/components/PageComponents/Password-Generator/PasswordGeneratorComponent.tsx
index 82c1054..65827cf 100644
--- a/src/components/PageComponents/Password-Generator/PasswordGeneratorComponent.tsx
+++ b/src/components/PageComponents/Password-Generator/PasswordGeneratorComponent.tsx
@@ -4,7 +4,6 @@ import Button from '../../Button/Button'
 import MiniCard from '../../MiniCard/MiniCard'
 // import ToggleSwtich from '../ToggleSwitch/ToggleSwitch'
 import { Slider } from '@kobalte/core/slider'
-import { Switch } from '@kobalte/core/switch'
 import { Alert } from '@kobalte/core/alert'
 import { Checkbox } from '@kobalte/core/checkbox'
 import { FaSolidCheck } from 'solid-icons/fa'
@@ -31,9 +30,10 @@ export default () => {
     setPassword(passwordArray.join(''))
   }
 
-  // Effect to update the display when the length changes
-  createEffect(() => {
-    generatePassword()
+  createEffect((value) => {
+    if (length() !== value) {
+      generatePassword()
+    }
   })
 
   const handleToggleChange = (target: string) => {